[Console] Refactor and cleanup of public and server by jloleysens · Pull Request #60513 · elastic/kibana

jloleysens · 2020-03-18T13:51:02Z

Summary

This cleanup targets:

Remove of Ace in public lib folder (specifically autocomplete.ts)
Refactor loading of console spec files (in a new service)

How to test

Try booting Console OSS and Xpack and check that the expected spec is there (like _ml endpoints in Xpack).
Check for any console errors at startup
Most of the changes are targetting spec and autocomplete, so anything that the user might expect those to do, that you can think of would be great to test.

Remove ace from lib/autocomplete.ts and set up hooking up of ace in legacy_core_editor. Also remove use of ace mocks in tests.

Refactored the loading of spec into a new SpecDefinitionsService. In this way, state can be contained inside of the service as much as possible. Also converted all JS spec to TS and updated the Console plugin contract so that processors (which alter loaded spec) happen at plugin "start" phase.

elasticmachine · 2020-03-18T13:51:04Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

jloleysens · 2020-03-18T14:03:59Z

src/plugins/console/public/application/models/sense_editor/__tests__/integration.test.js

-            done();
-            return;
-          }
+      senseEditor.autocomplete._test.getCompletions(senseEditor, null, cursor, '', function(


Preferably ignore these changes for now, they are mostly whitespace and the spec is hard to read. We should definitely address this at some point but for now they provide really decent coverage.

No worries, Github "Hide whitespace changes" makes this easy to parse 😊

…ole/cleanup * 'master' of github.com:elastic/kibana: (47 commits) [Remote clusters] Update copy (elastic#60382) Sort by name when fetching alerts and connectors (elastic#60506) Make slack param validation handle empty messages (elastic#60468) [Alerting] Adds navigation by consumer and alert type to alerting (elastic#58997) Introduce search interceptor (elastic#60523) [ML] Add functional tests for file data visualizer (elastic#60413) [APM] Optimize service map query (elastic#60412) [SIEM][Detection Engine] Adds lists feature flag and list values to the REST interfaces Enhancement/update esdocs datasource (elastic#59512) [junit] only include stdout in report for failures (elastic#60530) Update dependency nock to v12 (elastic#60422) upgrade execa to get stdout/stderr in error messages (elastic#60537) skip flaky suite (elastic#60471) [Ingest] Agent Config Details - Data sources list ui (elastic#60429) [SIEM] Create ML Rules (elastic#58053) skip flaky suite (elastic#60559) fix agent type (elastic#60554) Fixed default message for index threshold includes both threshold values (elastic#60545) [Ingest] Add support for `yaml` field types (elastic#60440) Solved the issue for a GROUP BY expression validation (elastic#60558) ...

sebelga

LGTM! Tested locally both oss and x-pack and could not spot any regression. 👍

sebelga · 2020-03-19T10:33:24Z

src/plugins/console/public/application/models/sense_editor/__tests__/integration.test.js

-            done();
-            return;
-          }
+      senseEditor.autocomplete._test.getCompletions(senseEditor, null, cursor, '', function(


No worries, Github "Hide whitespace changes" makes this easy to parse 😊

sebelga · 2020-03-19T10:38:37Z

src/plugins/console/public/lib/autocomplete/autocomplete.ts

-
  return {
+    getCompletions,
+    // TODO: This needs to be cleaned up


Yes! Exporting a special object for testing indicates some spaghetti code somewhere 😊

src/plugins/console/public/types/core_editor.ts

src/plugins/console/server/plugin.ts

- Updated naming of argument variable in registerAutocompleter - Refactored the SpecDefinitionsService to handle binding of it's own functions

kibanamachine · 2020-03-19T16:24:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5886a2a

History

💚 Build #34502 succeeded 3c1d020
💛 Build #34194 was flaky 87ddc60
💔 Build #34169 failed b16eb50

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Clean up use of ace in autocomplete in public Remove ace from lib/autocomplete.ts and set up hooking up of ace in legacy_core_editor. Also remove use of ace mocks in tests. * Added TODO in lib/kb (console public) * Server-side cleanup Refactored the loading of spec into a new SpecDefinitionsService. In this way, state can be contained inside of the service as much as possible. Also converted all JS spec to TS and updated the Console plugin contract so that processors (which alter loaded spec) happen at plugin "start" phase. * Fix types * Small refactor - Updated naming of argument variable in registerAutocompleter - Refactored the SpecDefinitionsService to handle binding of it's own functions

* Clean up use of ace in autocomplete in public Remove ace from lib/autocomplete.ts and set up hooking up of ace in legacy_core_editor. Also remove use of ace mocks in tests. * Added TODO in lib/kb (console public) * Server-side cleanup Refactored the loading of spec into a new SpecDefinitionsService. In this way, state can be contained inside of the service as much as possible. Also converted all JS spec to TS and updated the Console plugin contract so that processors (which alter loaded spec) happen at plugin "start" phase. * Fix types * Small refactor - Updated naming of argument variable in registerAutocompleter - Refactored the SpecDefinitionsService to handle binding of it's own functions Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

jloleysens added 3 commits March 18, 2020 12:18

Clean up use of ace in autocomplete in public

fe329a5

Remove ace from lib/autocomplete.ts and set up hooking up of ace in legacy_core_editor. Also remove use of ace mocks in tests.

Added TODO in lib/kb (console public)

834c0aa

jloleysens added Feature:Console Dev Tools Console Feature Feature:Dev Tools v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 18, 2020

jloleysens requested a review from sebelga March 18, 2020 13:51

Fix types

87ddc60

jloleysens commented Mar 18, 2020

View reviewed changes

cjcenizal mentioned this pull request Mar 19, 2020

[Console] Fix bool filter autocompletions and refactor #60361

Merged

sebelga approved these changes Mar 19, 2020

View reviewed changes

Small refactor

5886a2a

- Updated naming of argument variable in registerAutocompleter - Refactored the SpecDefinitionsService to handle binding of it's own functions

jloleysens merged commit 304b322 into elastic:master Mar 19, 2020

jloleysens deleted the refactor/console/cleanup branch March 19, 2020 16:32

jloleysens mentioned this pull request Mar 19, 2020

[7.x] [Console] Refactor and cleanup of public and server (#60513) #60652

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[Console] Refactor and cleanup of public and server#60513

[Console] Refactor and cleanup of public and server#60513
jloleysens merged 6 commits intoelastic:masterfrom
jloleysens:refactor/console/cleanup

jloleysens commented Mar 18, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Mar 18, 2020

Uh oh!

jloleysens Mar 18, 2020

Uh oh!

sebelga Mar 19, 2020

Uh oh!

sebelga left a comment

Uh oh!

sebelga Mar 19, 2020

Uh oh!

sebelga Mar 19, 2020

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Mar 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

jloleysens commented Mar 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to test

Uh oh!

elasticmachine commented Mar 18, 2020

Uh oh!

jloleysens Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

sebelga Mar 19, 2020

Choose a reason for hiding this comment

Uh oh!

sebelga left a comment

Choose a reason for hiding this comment

Uh oh!

sebelga Mar 19, 2020

Choose a reason for hiding this comment

Uh oh!

sebelga Mar 19, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Mar 19, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jloleysens commented Mar 18, 2020 •

edited

Loading